Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreground microphone fix #1797

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Foreground microphone fix #1797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4dd255
Added microphone service type in foreground service
Decoder07 Jul 4, 2024
ed58658
updated changelog
Decoder07 Jul 4, 2024
a07548f
released sample app version 1.5.211 (511) 🍀
Decoder07 Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/hmssdk_flutter/example/ExampleAppChangelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ https://app.devrev.ai/100ms/works/ISS-22834
- Noise cancellation layout API
https://app.devrev.ai/100ms/works/ISS-22858

- Sample application not able to access microphone from background in android 14.
https://app.devrev.ai/100ms/works/ISS-22907

Room Kit: 1.1.5
Core SDK: 1.10.5
Android SDK: 2.9.62
Expand Down
4 changes: 2 additions & 2 deletions packages/hmssdk_flutter/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ android {
applicationId "live.hms.flutter"
minSdkVersion 21
targetSdkVersion 34
versionCode 510
versionName "1.5.210"
versionCode 511
versionName "1.5.211"
}

signingConfigs {
Expand Down
4 changes: 2 additions & 2 deletions packages/hmssdk_flutter/example/ios/Runner/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.5.210</string>
<string>1.5.211</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand All @@ -48,7 +48,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>510</string>
<string>511</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationCategoryType</key>
Expand Down
2 changes: 1 addition & 1 deletion packages/hmssdk_flutter/example/lib/foreground_task_handler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Future<bool> initForegroundTask() async {
if (isPermissionsGiven) {
FlutterForegroundTask.init(
androidNotificationOptions: AndroidNotificationOptions(
foregroundServiceType: AndroidForegroundServiceType.CAMERA,
foregroundServiceType: AndroidForegroundServiceType.MICROPHONE,
channelId: '100ms_flutter_notification',
channelName: '100ms Flutter Notification',
channelDescription:
Expand Down
2 changes: 1 addition & 1 deletion packages/hmssdk_flutter/ios/Classes/SwiftHmssdkFlutterPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ public class SwiftHmssdkFlutterPlugin: NSObject, FlutterPlugin, HMSUpdateListene
return
}

hmsSDK?.preview(role: role) { tracks, error in
hmsSDK?.preview(role: role) { [self] tracks, error in

if let error = error {
print(#function, error)
Expand Down
Loading