Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR #2155

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Release PR #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b71943e
fix: snippet and mention minimum version requirement
KaustubhKumar05 Apr 17, 2024
390d8ac
Merge pull request #2154 from 100mslive/update-nc-docs
KaustubhKumar05 Apr 17, 2024
48cca60
fix: copy
KaustubhKumar05 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ So you don't have to copy paste common content multiple times.
## 🥵 Components

Components is what makes this docs standout
All Components mentioned are already auto imported so you don't need to do them.
All Components mentioned are auto imported.

Here's some of them added and can be easily added:

Expand Down
4 changes: 3 additions & 1 deletion ...cript/v2/how-to-guides/extend-capabilities/plugins/krisp-noise-cancellation.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ This guide provides an overview of usage of the noise suppression plugin of 100m

## Pre-requisites

Minimum version requirement for `hms-video-store` - 0.11.7

**Get the 100ms noise cancellation Package**

```bash section=GetHMSNoiseCancellationPackage sectionIndex=1
Expand Down Expand Up @@ -53,7 +55,7 @@ const plugin = new HMSKrispPlugin();
// check if audio track is available
const localAudioTrack = hmsStore.getState(selectLocalAudioTrackID);
let inProgress = false;
hmsStore.subscribe((isPluginAdded) => {
hmsStore.subscribe(async (isPluginAdded) => {
if(!isPluginAdded && !inProgress) {
inProgress = true;
await hmsActions.addPluginToAudioTrack(plugin);
Expand Down
Loading