Skip to content

Commit

Permalink
set pnpm version in root package instead of workflows to fix broken g…
Browse files Browse the repository at this point in the history
…ithub workflows (aptos-labs#7923)
  • Loading branch information
geekflyer authored Apr 26, 2023
1 parent 489000c commit e28a1d9
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 11 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/check-sdk-examples.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ jobs:
with:
node-version-file: .node-version
- uses: pnpm/action-setup@v2
with:
version: 8.2.0

# Run example code in typescript.
- uses: nick-fields/retry@7f8f3d9f0f62fe5925341be21c2e8314fd4f7c7c # pin@v2
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/copy-images-to-dockerhub.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ jobs:
password: ${{ secrets.ENV_DOCKERHUB_PASSWORD }}

- uses: pnpm/action-setup@537643d491d20c2712d11533497cb47b2d0eb9d5 # pin https://github.com/pnpm/action-setup/releases/tag/v2.2.3
with:
version: 7.13.4

- name: Release Images
env:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/grafana-sync.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # pin@v3
- uses: pnpm/action-setup@537643d491d20c2712d11533497cb47b2d0eb9d5 # pin https://github.com/pnpm/action-setup/releases/tag/v2.2.3
with:
version: 7.13.4
run_install: |
- recursive: false
args: [--frozen-lockfile]
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/lint-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ jobs:
with:
node-version-file: .node-version
- uses: pnpm/action-setup@v2
with:
version: 8.2.0

- run: pnpm lint
working-directory: developer-docs-site
- run: sudo apt update -y && sudo apt install -y aspell aspell-en
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/prune-old-workflow-runs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ jobs:
with:
node-version-file: .node-version
- uses: pnpm/action-setup@537643d491d20c2712d11533497cb47b2d0eb9d5 # pin https://github.com/pnpm/action-setup/releases/tag/v2.2.3
with:
version: 7.13.4

- run: pnpm i && pnpm pruneGithubWorkflowRuns
env:
GITHUB_TOKEN: ${{ github.token }}
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/sdk-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ jobs:
# Self hosted runners don't have pnpm preinstalled.
# https://github.com/actions/setup-node/issues/182
- uses: pnpm/action-setup@v2
with:
version: 8.2.0

# When using high-perf-docker, the CI is actually run with two containers
# in a k8s pod, one for docker commands run in the CI steps (docker), and
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"description": "This is a pure dependency package.json which installs dependencies for js utility scripts used in the repo",
"packageManager": "[email protected]",
"private": true,
"type": "module",
"devDependencies": {
Expand Down

0 comments on commit e28a1d9

Please sign in to comment.