Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subscribing to events via ws #652

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Support subscribing to events via ws #652

merged 10 commits into from
Nov 27, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Nov 22, 2024 •
edited
Loading

Usage related changes

Development related changes

  • Reuse existing event extraction logic (required exporting parts of old code).

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC marked this pull request as ready for review November 26, 2024 12:33
@FabijanC FabijanC merged commit 55fe695 into json-rpc-v0.8.0 Nov 27, 2024
1 check passed
@FabijanC FabijanC deleted the ws-methods-events branch November 27, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabijanC @marioiordanov