Submit verifications #855
Submit verifications #855
Conversation
aldigjo
force-pushed
the
submit_verifications
branch
from
b35afec to
3a2eeb1
Compare
| return CheckVerification200JSONResponse{union: json.RawMessage(fmt.Sprintf(`{"query": %v}`, query))}, nil | ||
| } | ||
|
|
||
| return CheckVerification404JSONResponse{N404JSONResponse{Message: "Verification query not found"}}, nil |
There was a problem hiding this comment.
default response should be 500. To return error 404 we'd check the error from the repository /service layer
|
|
||
| // VerificationService interface | ||
| type VerificationService interface { | ||
| CheckVerification(ctx context.Context, issuerID w3c.DID, verificationQueryID uuid.UUID) (*domain.VerificationResponse, *domain.VerificationQuery, error) |
There was a problem hiding this comment.
methods inside services should not contain the service name. Rename this to Check
| // VerificationService interface | ||
| type VerificationService interface { | ||
| CheckVerification(ctx context.Context, issuerID w3c.DID, verificationQueryID uuid.UUID) (*domain.VerificationResponse, *domain.VerificationQuery, error) | ||
| SubmitVerificationResponse(ctx context.Context, verificationQueryID uuid.UUID, issuerID w3c.DID, token string, serverURL string) (*domain.VerificationResponse, error) |
There was a problem hiding this comment.
methods inside services should not contain the service name. Rename this to SubmitResponse
|
Please, run golangci-lint (or make lint) and fix linter warnings. |
| } | ||
|
|
||
| nullifierSessionID := new(big.Int) | ||
| if _, ok := nullifierSessionID.SetString(val.(string), defaultBigIntBase); !ok { |
There was a problem hiding this comment.
We should check that this conversion to string is valid. If not we will have a core dump.
Something like this.
var sVal string
if sVal, ok = val.(string); ok {
return nil, errors.New("nullifierSessionID is not a string")
}
Working with map[string]interfaces needs a lot of boilerplate
| @@ -101,3 +105,28 @@ func (r *VerificationRepository) AddResponse(ctx context.Context, queryID uuid.U | |||
| } | |||
| return responseID, nil | |||
| } | |||
|
|
|||
| // GetVerificationResponse returns a verification response by scopeID and userDID | |||
| func (r *VerificationRepository) GetVerificationResponse(ctx context.Context, queryID uuid.UUID) (*domain.VerificationResponse, error) { | |||
There was a problem hiding this comment.
We need a test for this function in repositories/verification_test.go
aldigjo
force-pushed
the
submit_verifications
branch
from
392cf6f to
fdb7307
Compare
Adding verification endpoints