Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keys functionality #854

Merged
merged 76 commits into from
Dec 23, 2024
Merged

Add Keys functionality #854

merged 76 commits into from
Dec 23, 2024

Conversation

martinsaporiti
Copy link
Contributor

No description provided.

@martinsaporiti martinsaporiti self-assigned this Nov 29, 2024
Copy link

gitguardian bot commented Dec 2, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8664826 Triggered Generic Password 55411a9 k8s/testing/values.yaml View secret
14295020 Triggered Generic High Entropy Secret c25375b internal/kms/aws_secret_storage_provider_test.go View secret
14295020 Triggered Generic High Entropy Secret c25375b internal/kms/aws_secret_storage_provider_test.go View secret
14295020 Triggered Generic High Entropy Secret c25375b internal/kms/aws_secret_storage_provider_test.go View secret
14295020 Triggered Generic High Entropy Secret c0de516 internal/kms/aws_secret_storage_provider_test.go View secret
14295020 Triggered Generic High Entropy Secret c0de516 internal/kms/aws_secret_storage_provider_test.go View secret
14295020 Triggered Generic High Entropy Secret c0de516 internal/kms/file_storage_manager_test.go View secret
14295020 Triggered Generic High Entropy Secret c0de516 internal/kms/file_storage_manager_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@martinsaporiti martinsaporiti marked this pull request as ready for review December 2, 2024 15:05
@martinsaporiti martinsaporiti requested a review from a team as a code owner December 2, 2024 15:05
@Alexander-frenki Alexander-frenki requested a review from a team as a code owner December 10, 2024 08:27
Copy link
Contributor Author

@martinsaporiti martinsaporiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinsaporiti martinsaporiti merged commit ef00fd9 into develop Dec 23, 2024
3 checks passed
@martinsaporiti martinsaporiti deleted the add_key_endpoint branch December 23, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants