feat: support refresh service #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javip97
reviewed
Dec 15, 2023
| return nil | ||
| }, | ||
| // check if refresh service has supported type | ||
| func() error { |
There was a problem hiding this comment.
If RefreshService is set, expiration should be mandatory in that case, right? I'm missing that validation here
Taken from the docs: "Also, the issuer should set expiration field"
There was a problem hiding this comment.
Yes, you are right. I will fix.
martinsaporiti
approved these changes
Dec 15, 2023
…nID/issuer-node into feature/support-refresh-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently implemented a refresh service for short-lived credentials. If a credential includes a refreshService field, clients can now use this service to refresh credentials that have expired.
Typical Use Case:
For more details, please refer to our internal documentation: Refresh Service Documentation.
Link to the refresh service (⚠️ integration with the issuer-node is pending): GitHub - Refresh Service.Integration with the issuer-node is ready on refresh service side: 0xPolygonID/refresh-service#3