feat: calculate network id #212
Open
+58
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanestebanr
approved these changes
Dec 2, 2024
cmd/run.go
Outdated
| reorgDetectorL2 *reorgdetector.ReorgDetector, | ||
| l2Client *ethclient.Client, | ||
| ) *bridgesync.BridgeSync { | ||
| if !isNeeded([]string{cdkcommon.RPC, cdkcommon.AGGSENDER}, components) { | ||
| return nil | ||
| } | ||
|
|
||
| ethermanClient, err := newEtherman(c) |
There was a problem hiding this comment.
Instead of passing c config.Config to be able to create a ethClient, inject the etherClient. There are 2 functions on run.go that create the common instance for all classes:
runL1ClientIfNeededrunL2ClientIfNeeded
cmd/run.go
Outdated
| @@ -77,8 +77,8 @@ func start(cliCtx *cli.Context) error { | |||
|
|
|||
| l1InfoTreeSync := runL1InfoTreeSyncerIfNeeded(cliCtx.Context, components, *c, l1Client, reorgDetectorL1) | |||
| claimSponsor := runClaimSponsorIfNeeded(cliCtx.Context, components, l2Client, c.ClaimSponsor) | |||
| l1BridgeSync := runBridgeSyncL1IfNeeded(cliCtx.Context, components, c.BridgeL1Sync, reorgDetectorL1, l1Client) | |||
| l2BridgeSync := runBridgeSyncL2IfNeeded(cliCtx.Context, components, c.BridgeL2Sync, reorgDetectorL2, l2Client) | |||
| l1BridgeSync := runBridgeSyncL1IfNeeded(cliCtx.Context, components, *c, reorgDetectorL1, l1Client) | |||
There was a problem hiding this comment.
I know that is not related to your PR, but renaming c for config or even for cfg would be really nice
|
Stefan-Ethernal
approved these changes
Dec 3, 2024
|
|
||
| return 0, fmt.Errorf("error calling SMC RollupManager.RollupAddressToID(%s). Err: %w", rollupAddr.String(), err) | ||
| } | ||
| log.Infof("rollupID: %d (obtenied from SMC: %s )", rollupID, contracts.Banana.RollupManager.String()) |
There was a problem hiding this comment.
Suggested change
| log.Infof("rollupID: %d (obtenied from SMC: %s )", rollupID, contracts.Banana.RollupManager.String()) | |
| log.Infof("rollupID: %d (obtained from contract: %s )", rollupID, contracts.Banana.RollupManager.String()) |
| if err != nil { | ||
| log.Errorf("error getting rollupID from %s : %+v", contracts.Banana.RollupManager.String(), err) | ||
|
|
||
| return 0, fmt.Errorf("error calling SMC RollupManager.RollupAddressToID(%s). Err: %w", rollupAddr.String(), err) |
There was a problem hiding this comment.
Suggested change
| return 0, fmt.Errorf("error calling SMC RollupManager.RollupAddressToID(%s). Err: %w", rollupAddr.String(), err) | |
| return 0, fmt.Errorf("error calling contract RollupManager.RollupAddressToID(%s). Err: %w", rollupAddr.String(), err) |
| } | ||
| rollupID, err := contracts.Banana.RollupManager.RollupAddressToID(&bind.CallOpts{Pending: false}, rollupAddr) | ||
| if err != nil { | ||
| log.Errorf("error getting rollupID from %s : %+v", contracts.Banana.RollupManager.String(), err) |
There was a problem hiding this comment.
Suggested change
| log.Errorf("error getting rollupID from %s : %+v", contracts.Banana.RollupManager.String(), err) | |
| log.Errorf("error getting rollupID from %s: %v", contracts.Banana.RollupManager.String(), err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calculate network ID instead of reading it from config