Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force scheme in SUBSTREAMS_ENDPOINT_URL #12

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Force scheme in SUBSTREAMS_ENDPOINT_URL #12

merged 1 commit into from
Jan 11, 2025

Conversation

YaroShkvorets
Copy link
Contributor

Otherwise, if you don't include protocol it fails to connect with non-obvious error:

sink-1   | Unable to connect to endpoint: status: Unknown, message: "transport error", details: [], metadata: MetadataMap { headers: {} }: transport error: invalid URI
sink-1   | Unable to connect to endpoint: status: Unknown, message: "transport error", details: [], metadata: MetadataMap { headers: {} }: transport error: invalid URI
sink-1   | Unable to connect to endpoint: status: Unknown, message: "transport error", details: [], metadata: MetadataMap { headers: {} }: transport error: invalid URI

cvauclair
cvauclair approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@cvauclair cvauclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the PR!

@cvauclair cvauclair merged commit 4e5f2a2 into 0xPlaygrounds:main Jan 11, 2025
4 checks passed
@YaroShkvorets YaroShkvorets deleted the yaro/force-scheme branch January 13, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvauclair cvauclair cvauclair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YaroShkvorets @cvauclair