Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: instead of 0:00 UTC, run at 1:24 UTC #18

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

0xB10C
Copy link
Owner

@0xB10C 0xB10C commented Nov 6, 2024

From time to time, the cron based GitHub action runs at 0:00 UTC fail (https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/actions) with a 403 error from the OFAC website.

--2024-11-06 00:34:47--  https://sanctionslistservice.ofac.treas.gov/api/PublicationPreview/exports/SDN_ADVANCED.ZIP
Resolving sanctionslistservice.ofac.treas.gov (sanctionslistservice.ofac.treas.gov)... 164.95.9.80, 2610:108:3100:100c::9:290
Connecting to sanctionslistservice.ofac.treas.gov (sanctionslistservice.ofac.treas.gov)|164.95.9.80|:443... connected.
HTTP request sent, awaiting response... 403 Forbidden
2024-11-06 00:34:48 ERROR 403: Forbidden.

There a multiple possibilites why this could be happening:

  • Too many jobs try to access the file around 0:00 UTC and potential rate-limiting triggers
  • The file is being updated at that time

Move the time to 1:24 UTC (randomly choosen) to possibly avoid this. I don't see how this could hurt.

From time to time, the cron based GitHub action runs at 0:00 UTC fail
(https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/actions)
with a 403 error from the OFAC website.

```
--2024-11-06 00:34:47--  https://sanctionslistservice.ofac.treas.gov/api/PublicationPreview/exports/SDN_ADVANCED.ZIP
Resolving sanctionslistservice.ofac.treas.gov (sanctionslistservice.ofac.treas.gov)... 164.95.9.80, 2610:108:3100:100c::9:290
Connecting to sanctionslistservice.ofac.treas.gov (sanctionslistservice.ofac.treas.gov)|164.95.9.80|:443... connected.
HTTP request sent, awaiting response... 403 Forbidden
2024-11-06 00:34:48 ERROR 403: Forbidden.
```

There a multiple possibilites why this could be happening:
- Too many jobs try to access the file around 0:00 UTC and potential
  rate-limiting triggers
- The file is being updated at that time

Move the time to 1:24 UTC (randomly choosen) to possibly avoid this.
I don't see how this could hurt.
@@ -4,7 +4,7 @@ name: Generate OFAC sanctioned digital currency addresses lists each night at 0

on:
schedule:
- cron: '0 0 * * *'
- cron: '24 1 * * *'
Copy link
Owner Author

@0xB10C 0xB10C Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://crontab.guru/#24_1_*_*_*

Copy link
Owner Author

@0xB10C 0xB10C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xB10C 0xB10C merged commit 33c2218 into main Nov 6, 2024
1 check passed
@0xB10C 0xB10C deleted the 2024-11-move-cron-time-back branch November 6, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant