Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Awesome Protocols #351

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Add Awesome Protocols #351

merged 2 commits into from
Oct 28, 2022

Conversation

0exbot
Copy link

@0exbot 0exbot commented Oct 28, 2022

Pull request from @chrvadala.

[ boilerplate snipped ]

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-sindresorhus on 2020-12-20 05:12 says: Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-fityanos on 2020-12-20 05:36 says: @-chrvadala

  • PR title should be "Add Awesome Protocols" instead of "Add awesome protocols"
  • unicorn comment is missing

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-chrvadala on 2020-12-20 10:19 says: unicorn

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-chrvadala on 2020-12-20 10:24 says: @-fityanos thanks for your suggestions

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-sindresorhus on 2021-03-07 12:01 says:

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it.

Read it again. You missed multiple points.

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-sindresorhus on 2021-04-24 18:24 says: Closing for lack of response and also the list is too far from being mergeable.

readme.md Outdated
@@ -373,6 +373,7 @@
- [Competitive Programming](https://github.com/lnishan/awesome-competitive-programming#readme)
- [Math](https://github.com/rossant/awesome-math#readme)
- [Recursion Schemes](https://github.com/passy/awesome-recursion-schemes#readme) - Traversing nested data structures.
- [Awesome Protocols](https://github.com/chrvadala/awesome-protocols) - Main protocols and open standards with RFC links.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@-sindresorhus on 2021-03-07 12:00 says: Not clear what "main protocols" is supposed to mean.

Your entry here also doesn't follow the guidelines. Please compare yours to the others.

@akvadrako akvadrako merged commit 9168858 into main Oct 28, 2022
@akvadrako akvadrako deleted the pull/1922 branch October 28, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants