Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gosdk #656

Merged
merged 1 commit into from
Dec 11, 2024
Merged

update gosdk #656

merged 1 commit into from
Dec 11, 2024

Conversation

Hitenjain14
Copy link
Member

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@Hitenjain14 Hitenjain14 requested a review from dabasov December 11, 2024 11:57
dabasov
dabasov approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit d89c4bc into staging Dec 11, 2024
4 of 7 checks passed
@dabasov dabasov deleted the update/gosdk-1.18.3 branch December 11, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hitenjain14 @dabasov