Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search support #77

Merged
merged 22 commits into from
Nov 22, 2024
Merged

Implement search support #77

merged 22 commits into from
Nov 22, 2024

Conversation

docs/customization/pages.rst Outdated Show resolved Hide resolved
@Gallaecio Gallaecio marked this pull request as ready for review November 11, 2024 13:02
@Gallaecio Gallaecio requested a review from wRAR November 11, 2024 13:02
@Gallaecio Gallaecio marked this pull request as draft November 12, 2024 13:03
@Gallaecio Gallaecio marked this pull request as ready for review November 12, 2024 14:03
@Gallaecio
Copy link
Contributor Author

I was planning to log an error when we cannot build a request, but it was my bad to think we did not because no error was logged in the spider, we log it from the page object already and have tests for it. 🤦

@Gallaecio Gallaecio merged commit e9bf031 into zytedata:main Nov 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants