New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copyrights are missing in the license file. #10

Open

MarkAshraf96 opened this issue Nov 7, 2024 · 0 comments

MarkAshraf96 commented Nov 7, 2024

Hello, I noticed that the Apache 2.0 License boilerplate is not filled with the copyrights owner, adding it would be highly appreciated.

I noticed that you already use a copyright statement in your other repos as in here:
https://github.com/zxing-js/library/blob/0e68da880f64974746083431f3442c29835eddda/src/core/aztec/encoder/Token.ts#L1-L15
it would be also a best practice to include it directly in the Apache 2.0 License boiler plate.

I can easily create a PR with that change if you allow it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment