-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Scenes retriggers after zwavejs2mqtt restart #434
Comments
@haavardNO Fix ready |
* fix: ignore stateless valueId updates if from cache Fixes #434 * fix: lint issues
Did you delete all retained messages from mqtt broker right? @billiaz Could you help in this? |
Let me check if my Scenes retain of course I can! |
@robertsLando I do see these getting retained on my broker too. But without value! |
@haavardNO state 0 means inactive right? should this be empty? I see MQTT refreshes value and cleans it after 1 second but the payload is there without value. Looking into my Button from Aeotec I have this {
"type": "sensor",
"object_id": "scene_state_scene_001",
"discovery_payload": {
"state_topic": "zwave2mqtt/MasterBedroom/VassilisSwitch/91/0/scene/001",
"value_template": "{{ value_json.value}}",
"json_attributes_topic": "zwave2mqtt/MasterBedroom/VassilisSwitch/91/0/scene/001",
"device": {
"identifiers": [
"zwavejs2mqtt_0xcddb486e_node60"
],
"manufacturer": "Aeotec Ltd.",
"model": "NanoMote Quad (Aeotec NanoMote Quad)",
"name": "MasterBedroom-VassilisSwitch",
"sw_version": "1.2"
},
"name": "MasterBedroom-VassilisSwitch Scene 001",
"unique_id": "zwavejs2mqtt_0xcddb486e_60-91-0-scene-001"
},
"discoveryTopic": "sensor/MasterBedroom-VassilisSwitch/scene_state_scene_001/config",
"values": [
"91-0-scene-001"
],
"persistent": false,
"ignoreDiscovery": false,
"id": "sensor_scene_state_scene_001"
} most probably this: can you share with us your node export and also the specific MQTT payload under the device? |
state 0 means button press. So the system triggers on state 0.
Sorry but I was a bit trigger happy there. |
I have the same behavior on both the aeotec quadmote and the fibaro keyfob. |
It can be hass behaves differently in this case! I suggest to move to a new issue and investigate the template we send to hass! this way we might be able to fix the HASS only part. |
@robertsLando please advise on how to proceed. Should I create yet another case? |
@haavardNO this retriggers on HASS side right? I suggest to create a new issue for the HASS side in that case. |
@billiaz Yes, it triggers on HASS side. But the values has to come from something. Even after I delete the toppics it retriggers. |
Please open an issue here, not on hass, for the hass discovery. To get a try fix it. |
@haavardNO HASS caches the last value, when we send a state without value keeps the old. this means we need some how to reset it. |
@billiaz thanks for the explanation. see #486 Please note that the original zwave2mqtt handled this a bit differently. There the state was set to inactive unless it was activated, then back to inactive again. |
The zwave2mqtt was using ozw, where zwavejs2mqtt is using node-zwave-js. OZW was controlling 99.9% of how you talk to device, what you get... sometimes outside the spec. the case we are talking is the same. OZW was "performing" extra actions outside spec. In the other hand zwave-js is keeping bit 99,999% if not 100% the specs. This leads to differences. Now home assistant has a bit different approach. This means we need to link home assistant's thinking to the app's thinking. |
@billiaz has there been any development on this issue? |
I have moved to the new WS Server option. |
Ok @haavardNO, let me know! |
Hi, I have exactly the same issue. Did you solve it? |
Before submitting a bug please read: https://zwave-js.github.io/zwavejs2mqtt/#/troubleshooting/bug_report
Version 1.0.1
Build/Run method
Describe the bug
As discussed with @robertsLando I am creating a separate issue.
When restarting the application Home Assistant will re-trigger a scene, and in my case open my garage.
Looks as the "0" state is set back after restart, and this is what is used as trigger.
I think the zwave2mqtt version used "inactive" as the default state, and changed it to 0 only when triggered, then back to inactive. Maybe this could solve the issue?
To Reproduce
I have this issue with a fibaro keyfob that is used as a scene controller. I have the following automation in HA
The text was updated successfully, but these errors were encountered: