Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings tab keeps prompting about unsaved changes, even after saving #4010

Open
AlCalzone opened this issue Nov 14, 2024 · 2 comments · May be fixed by #4029
Open

Settings tab keeps prompting about unsaved changes, even after saving #4010

AlCalzone opened this issue Nov 14, 2024 · 2 comments · May be fixed by #4029
Labels
bug Something isn't working

Comments

@AlCalzone
Copy link
Member

To reproduce:

  1. Generate a fresh installation:
rm -rf build/
npm run bundle
node build/index.js
  1. Go to settings

    • Change serial port
    • Generate all S2 keys
    • Click SAVE
  2. Go back to dashboard:
    grafik

@AlCalzone AlCalzone added the bug Something isn't working label Nov 14, 2024
robertsLando added a commit that referenced this issue Nov 22, 2024
@robertsLando robertsLando linked a pull request Nov 22, 2024 that will close this issue
@robertsLando
Copy link
Member

robertsLando commented Nov 22, 2024

@AlCalzone When you go back to dashboard are you sure the action of saving is completed? The spinner on save button is gone away? Because I only can replace this if I exit from settings while saving is still running (can take some seconds)

@AlCalzone
Copy link
Member Author

Even then - if it is currently saving, it should not ask about unsaved changes. Only if I changed something since pressing the save button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants