Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT Discovery: Light objects should report supported_color_modes #3894

Closed
3 tasks done
dwmw2 opened this issue Sep 16, 2024 · 2 comments · Fixed by #3895
Closed
3 tasks done

MQTT Discovery: Light objects should report supported_color_modes #3894

dwmw2 opened this issue Sep 16, 2024 · 2 comments · Fixed by #3895
Labels
bug Something isn't working

Comments

@dwmw2
Copy link

dwmw2 commented Sep 16, 2024

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Manually built (git clone - npm run build - npm install

Z-Wave JS UI version

9.18.1

ZwaveJS version

13.3.0

Describe the bug

Light objects are advertised for MQTT AutoDiscovery using an out-of-date method.

The documentation at https://developers.home-assistant.io/docs/core/entity/light/ says that all lights should report supported_color_modes, including those which only support ColorMode.BRIGHTNESS or ColorMode.ONOFF.

To Reproduce

Use a Z-Wave light/dimmer device, and see the contents of its discovery topic.

Expected behavior

I expected to see

  supported_color_modes: ["brightness"],

or

  supported_color_modes: ["onoff"],

in the device configuration object.

Additional context

No response

@robertsLando
Copy link
Member

@dwmw2 Prepared a fix on #3895

@dwmw2
Copy link
Author

dwmw2 commented Sep 16, 2024

That was fast. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants