Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartStart status in Control Panel #3516

Closed
trainman419 opened this issue Jan 14, 2024 · 13 comments · Fixed by #3527
Closed

SmartStart status in Control Panel #3516

trainman419 opened this issue Jan 14, 2024 · 13 comments · Fixed by #3527
Assignees
Labels
enhancement New feature or request

Comments

@trainman419
Copy link

Is your feature request related to a problem? Please describe.
I've been adding a bunch of SmartStart devices over the past few weeks, and I find myself watching the logs to determine

  • Is the hub in SmartStart listening mode? (Or did it get stuck in inclusion somewhere?)
  • Has a new device been discovered? Did SmartStart succeed or fail?

I find that the logs indicate that a new device has been discovered within a few seconds, but the UI takes 30-60 seconds before it shows that the node has been added successfully.

Describe the solution you'd like
It would be great to be able to see the SmartStatus status somewhere in the Control Panel; maybe along with the other icons in the upper left?

Describe alternatives you've considered
🤷 . I'm open to other UI ideas; this is just the first thing that came to mind.

Additional context
Add any other context or screenshots about the feature request here.

@trainman419 trainman419 added the enhancement New feature or request label Jan 14, 2024
@robertsLando
Copy link
Member

robertsLando commented Jan 15, 2024

Actually I'm not sure if there are even apis on driver in order to get such status. @AlCalzone any clue?

@AlCalzone
Copy link
Member

AlCalzone commented Jan 15, 2024

Need to double check. Could be a nice feature to have if it's not available yet.

@kpine
Copy link
Contributor

kpine commented Jan 15, 2024

The Driver provides controller.inclusionState property. It will always be SmartStart if SmartStart is supported and it is idle, and change accordingly based on the documented states. The HA frontend uses this to dynamically add a cancel inclusion button to show inclusion status, disable exclusion button, and disable inclusion button.

@AlCalzone
Copy link
Member

Thanks!

@robertsLando
Copy link
Member

@kpine Is there also an event emitted to watch for inclusion state changes? Cannot find it

@AlCalzone
Copy link
Member

AlCalzone commented Jan 16, 2024

There isn't. --> zwave-js/node-zwave-js#6609

@robertsLando
Copy link
Member

So the alternative for now would be to just do a periodic check with an interval I think

@AlCalzone
Copy link
Member

At least while you don't know there is an active inclusion or exclusion. Those have events.

@robertsLando
Copy link
Member

robertsLando commented Jan 17, 2024

I already show inclusion/exclusion status in top bar, would that be enough ? 🤔 Maybe I can also add the other statuses like busy and so on

@trainman419
Copy link
Author

I already show inclusion/exclusion status in top bar, would that be enough ? 🤔 Maybe I can also add the other statuses like busy and so on

I find the top bar a bit confusing; it seems like it shows the most recent message or action (like Backup NVM progress: 100% ), but it's hard to tell how old that message is, so it's hard to tell if it indicates and action that is in progress, or an action that completed successfully. ( But that's a much bigger conversation than the original request here. )

With that in mind, I'd be happier with a dedicated status widget, but even showing the inclusion/exclusion status in the top bar would be great for visibility.

@robertsLando
Copy link
Member

I'm thinking about where to put it so, maybe an icon next to that with different colors:

 /** The controller isn't doing anything regarding inclusion. */
 Idle = Grey
    /** The controller is waiting for a node to be included. */
 Including = Purple
    /** The controller is waiting for a node to be excluded. */
Excluding = Red
    /** The controller is busy including or excluding a node. */
 Busy = Yellow
    /** The controller listening for SmartStart nodes to announce themselves. */
 SmartStart = Blue

With a tooltip shown when you hover

@robertsLando
Copy link
Member

See #3527 (comment) for a preview

@trainman419
Copy link
Author

Amazing! Yes, that's exactly what I was hoping for! Thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants