Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted #3439

Merged
merged 4 commits into from
Nov 27, 2023
Merged

fix: don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted #3439

merged 4 commits into from
Nov 27, 2023

Conversation

alexojegu
Copy link
Contributor

Currently, if ZWAVEJS_LOGS_DIR is setted, the STORE_DIR/logs directory continues to be created without any content being saved in it.

@alexojegu
Don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted.
761bb1a 
Currently, if `ZWAVEJS_LOGS_DIR` is setted, the `STORE_DIR/logs` directory continues to be created without any content being saved in it.
@alexojegu alexojegu changed the title Don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted. feat(config): don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted. Nov 26, 2023
@alexojegu alexojegu changed the title feat(config): don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted. feat(config): don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted Nov 26, 2023
robertsLando
robertsLando previously approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando changed the title feat(config): don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted fix(config): don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted Nov 27, 2023
@robertsLando robertsLando changed the title fix(config): don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted fix: don't create STORE_DIR/logs if ZWAVEJS_LOGS_DIR is setted Nov 27, 2023
@robertsLando robertsLando enabled auto-merge (squash) November 27, 2023 11:15
@robertsLando
Copy link
Member

@zwave-js-bot fix lint

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7004255283

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 21.379%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/lib/ZwaveClient.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 7004054803: 0.008%
Covered Lines: 3734
Relevant Lines: 18594
💛 - Coveralls

@robertsLando robertsLando merged commit 46773f7 into zwave-js:master Nov 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexojegu @robertsLando @coveralls @zwave-js-bot