Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Review Entire Fields in Node Section on Mobile #3415

Open
3 tasks done
The00Dustin opened this issue Nov 12, 2023 · 7 comments
Open
3 tasks done

Can't Review Entire Fields in Node Section on Mobile #3415

The00Dustin opened this issue Nov 12, 2023 · 7 comments
Labels
bug Something isn't working no-stale

Comments

@The00Dustin
Copy link
Contributor

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Docker

Z-Wave JS UI version

9.3.2

ZwaveJS version

12.3.0

Describe the bug

I cannot see the full data for fields in the node section when said exceeds the width of the field. More specifically, I am unable to see the data the extends past the end of a field by holding a tap to drag the cursor or by double-tapping to highlight a word and then trying to extend the highlighted section. This issue appears to be specific to mobile, as it is possible to see the same data using arrow keys or by highlighting via the mouse when using a desktop browser. I am using the Z-Wave JS UI addon, where I was able to reproduce the behavior via the iOS HA Helper App and via Firefox for iOS.

To Reproduce

On a mobile / touch-only device:

  1. Type a name longer than the field, bonus points if the last character before the field starts scrolling is a space.
  2. Save the name using the paper airplane button.
  3. Leave the UI and return in order to see the refreshed name.
  4. Try to view the part of the name that extends past the end of the field.

Expected behavior

I should be able to scroll through the text using a cursor or highlighting, or the field should extend (either when selected, or all the time) in such a way that all text is visible (for instance, by wrapping the text instead of extending it beyond the end of the field).

Additional context

No response

@The00Dustin The00Dustin added the bug Something isn't working label Nov 12, 2023
@robertsLando
Copy link
Member

robertsLando commented Nov 13, 2023

Are you speaking about node name/location or ALL fields?

@The00Dustin
Copy link
Contributor Author

I didn't test other fields, but upon closer review, I suspect the only fields that could be affected by this would be Name and Location. When I was typing this up, I forgot Values was inside of Node, but had already assumed those fields wouldn't have this problem. Upon closer inspection, I doubt the Send Options would, either.

@robertsLando
Copy link
Member

@The00Dustin Could you provide me a screenshot or a screen recordin please? I tried to reproduce this on my end without success...

@The00Dustin
Copy link
Contributor Author

The00Dustin commented Nov 14, 2023

*First attempt to upload didn't work, will try again.

@The00Dustin
Copy link
Contributor Author

Hopefully it works this time.
https://github.com/zwave-js/zwave-js-ui/assets/91274634/2134d86e-fc82-455e-9a12-f66135f88535

After I show both methods of attempting to see the rest of the text, I show the text by deleting a word, you can see the backspace button on the keyboard get tapped to verify this.

@robertsLando
Copy link
Member

robertsLando commented Nov 15, 2023

@The00Dustin Thanks for the recording, I saw it but unfortunately I don't think I can do much, the input I'm using is from vuetify and it may be a bug in their framework. I will dig into this to see if I can find a solution.

I tried both with dev tool emulation and with my iPhone and both work correctly (I can scroll the input) so I dunno how to help

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-stale
Projects
None yet
Development

No branches or pull requests

2 participants