chore(deps): security upgrade axios from 1.5.1 to 1.6.0 #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsLando
changed the title
|
On holiday. Will look in a few days |
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AXIOS-6032459
chrisns
force-pushed
the
snyk-fix-39d19f89e2774cc34c8c79fbe864ac9f
branch
from
84728e6 to
9b1b26f
Compare
Pull Request Test Coverage Report for Build 7009340372
💛 - Coveralls |
robertsLando
requested changes
Nov 27, 2023
| @@ -39,9 +39,8 @@ RUN npm_config_build_from_source=true npm rebuild @serialport/bindings-cpp | |||
| # Build back and frontend only when not existing | |||
| RUN [ -d 'dist' ] && echo "Skipping build" || npm run build | |||
|
|
|||
| RUN npm prune --production && \ | |||
| RUN yarn workspaces focus --production && \ | |||
There was a problem hiding this comment.
I think you added this change in the wrong branch :) could you create a new pr?
There was a problem hiding this comment.
No, was on purpose. Npm couldn't reconcile the deps. This is yarn equivalent
There was a problem hiding this comment.
I replaced yarn on purpose because the previous yarn command was throwing Could't allocate enough memory in arm32 builds... Anyway I can try to merge this to see how it goes and revert in case...
robertsLando
requested changes
Nov 28, 2023
| @@ -120,7 +120,8 @@ | |||
| "@zwave-js/winston-daily-rotate-file": "^4.5.6-1", | |||
| "ansi_up": "^6.0.2", | |||
| "archiver": "^6.0.1", | |||
| "axios": "^1.5.1", | |||
| "axios": "^1.6.2", | |||
| "axios-progress-bar": "^1.2.0", | |||
There was a problem hiding this comment.
Oh. Must have been a merge conflict. I'll update.
auto-merge was automatically disabled
December 13, 2023 13:22
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by Snyk using the credentials of a real user.
Snyk has created this PR to fix one or more vulnerable packages in the `yarn` dependencies of this project.
Changes included in this PR
Note for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed
With an upgrade:
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 7.1
SNYK-JS-AXIOS-6032459
(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Request Forgery (CSRF)