Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling changlog window on startup #3358

Closed
mmattel opened this issue Oct 18, 2023 · 9 comments
Closed

Handling changlog window on startup #3358

mmattel opened this issue Oct 18, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@mmattel
Copy link

mmattel commented Oct 18, 2023

Is your feature request related to a problem? Please describe.
Handling changlog window on startup

Describe the solution you'd like
Move the "dont show + ok block" from the bottom to the top, else you always need to fully scroll down to close it.

Describe alternatives you've considered
Scrolling down to the bottom and over time the changelog list will be big which then becomes annoying.

Additional context
I like the changlog being presented but scrolling down just to close it where I am interested in the latest changes is really not that good.

@mmattel mmattel added the enhancement New feature or request label Oct 18, 2023
@robertsLando
Copy link
Member

robertsLando commented Oct 18, 2023

@mmattel The don't show disables it forever, not just for the actual release. Once you press ok you will not see that changelog anymore until next release

@mmattel
Copy link
Author

mmattel commented Oct 18, 2023

I know, I suggest to have that block on top

@robertsLando
Copy link
Member

Reason it is on bottom is that reading changelogs is highly suggested so you should scroll to bottom in order to read it all, like when you have to accept terms in a website it force you to scroll the entire page in order to go on. I would like to know others opinion on this as I'm open to change this behaviour but I actually did it on purpose for the reasons described above

@AlCalzone
Copy link
Member

AlCalzone commented Oct 18, 2023

where I am interested in the latest changes

I don't understand the request then. The changelog should show only the changes that were made since you read them last.

@mmattel
Copy link
Author

mmattel commented Oct 18, 2023

The changelog should show only the changes that were made since you read them last.

If the changelog would only show the changes of the particular release, I would be fine with the current state. But as long it shows all changes, imagine +20 releasen in the future, scrolling the list to the bottom for options becomes a nightmare.

@robertsLando
Copy link
Member

robertsLando commented Oct 18, 2023

It has a limit of 10 releases btw I can also reduce this limit, that said in the worse case the scroll has to be done just one time every time you do a release, if you have 10 releases means you don't update it so often

Also you can disable it and since someone keeps it enabled means he want to see it and scrolling would not be a problem.

This is just my opinion but I may be wrong 🙌🏻

@mmattel
Copy link
Author

mmattel commented Oct 19, 2023

Also you can disable it and since someone keeps it enabled means he want to see it and scrolling would not be a problem.

This assupmtion is imho not correct. One wants to look for the changes of the current release and not for all in the list. Disabling would mean not showing the list at all - even not for the current release. Limiting the amount of changelogs shown could be a alternative solution, but the number should be quite low, I would say 2. The current and the former.

@robertsLando
Copy link
Member

robertsLando commented Oct 19, 2023

@mmattel In the changelog you see all changes made from the version you was to the one you just installed so IMO say "I want to see only latest changes" makes no sense. I mean for example if you update to a patch release with just a minor bug fix you would miss all the intermediate important changes 🤷🏼‍♂️

The reason to see multiple releases is to show you every single feature/patch made since your last update and that's the main purpose of a changelog

@AlCalzone
Copy link
Member

AlCalzone commented Oct 19, 2023

One wants to look for the changes of the current release and not for all in the list

So, if you were to update from v8.26.0 to v9.1.2, you would only want to see this

add setting to enable new version notification

and not the breaking changes that happened in v9.0.0 and the explanation what you might have to do to get things fixed again?

Minimum NodeJS version is now 18
If ZUI doesn’t work as expected after updating please check this issue and follow the steps described here: zwave-js/node-zwave-js#6341
... etc

That seems wrong IMO.

@zwave-js zwave-js locked and limited conversation to collaborators Oct 19, 2023
@robertsLando robertsLando converted this issue into discussion #3363 Oct 19, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants