Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect variable name? #3327

Closed
kpine opened this issue Oct 7, 2023 · 3 comments
Closed

Incorrect variable name? #3327

kpine opened this issue Oct 7, 2023 · 3 comments

Comments

@kpine
Copy link
Contributor

kpine commented Oct 7, 2023

I think this should be powerlevel, not powerLevel?

powerLevel: undefined,

Referenced here (I think):

zwave-js-ui/lib/ZwaveClient.ts

Lines 2137 to 2143 in 1741fac

if (
txPower &&
typeof txPower.measured0dBm === 'number' &&
typeof txPower.powerlevel === 'number'
) {
zwaveOptions.rf.txPower = txPower
}

I don't think it's causing an issue if you change settings via the UI, but something I noticed.

@BenjaminQuandt
Copy link

Both should be powerLevel, not powerlevel as u want to stay with camelcase!
https://google.github.io/styleguide/tsguide.html#identifiers

But I think u have a point in reporting inconsistent variables.

@kpine
Copy link
Contributor Author

kpine commented Oct 8, 2023

powerlevel is correct, it's one word in all Z-Wave docs.

@robertsLando
Copy link
Member

@kpine Yes, typo! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants