-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZST39 is probably corrupting the ACK after a soft reset #6399
Comments
👋 Hey @jtbraun! It looks like you attached a logfile, but its filename doesn't look like it a driver log that came from Z-Wave JS. Please make sure you upload the correct one. |
Hmm, I've seen something similar with the "official" USB controllers too: https://community.silabs.com/s/question/0D58Y00009pca5bSAA/bug-in-firmware-7191-softreset-is-no-longer-answered-with-ack?language=en_US The 7.19 firmware is just broken :( |
Oh how annoying. Is the firmware something that silicon labs mostly writes and distributes to stick vendors, they customize it (with LEDs, buttons, etc), and ship it? |
Correct. I have a semi-direct contact to Silabs and made them aware of it again. Hopefully this gains some traction now. |
Fix is up here: #6409 |
Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within Z-Wave JS UI (formerly ZwaveJS2MQTT)?
NO, my problem is NOT within Z-Wave JS UI
Checklist
I have checked the troubleshooting section and my problem is not described there.
I have read the changelog and my problem was not mentioned there.
Describe the bug
What causes the bug?
The issue of a soft reset to a ZST39 during the startup phase.
What do you observe?
Soft reset is issued, and an 0x86 byte is immediately received and discarded. Then the SerialAPIStarted message comes in, and later the driver complains that an ACK was never received.
What did you expect to happen?
ACK would be received.
Steps to reproduce the behavior:
test/run.ts
aka "Debug locally" test in vscodeModifying
packages/serial/src/parsers/SerialAPIParser.ts
to also accept 0x86 as "ACK" gets past the error.NOTE: I've reported the issue to Zooz, if I hear back from them I'll let you know. In the meantime, there probably needs to be a quirk flag or something that is set in the serialAPIParser specifically when softreset is waiting on an ACK, that treats a discarded byte as the missing ACK. :-/
Device information
Manufacturer: ZOOZ
Model name: ZST39
Node ID in your network: 1
How are you using
node-zwave-js
?zwave-js-ui
(formerlyzwavejs2mqtt
) Docker image (latest)zwave-js-ui
(formerlyzwavejs2mqtt
) Docker image (dev)zwave-js-ui
(formerlyzwavejs2mqtt
) Docker manually built (please specify branches)ioBroker.zwave2
adapter (please specify version)HomeAssistant zwave_js
integration (please specify version)pkg
node-red-contrib-zwave-js
(please specify version, double click node to find out)Which branches or versions?
version: master (9818c58)
node-zwave-js
branch: masterzwave-js-ui
branch: n/aDid you change anything?
yes (please describe)
If yes, what did you change?
I changed the COM port to COM3 instead of COM5 in run.ts
Did this work before?
Don't know, this is a new device
If yes, where did it work?
n/a
Attach Driver Logfile
zwave.log
The text was updated successfully, but these errors were encountered: