Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching to 16-bit node IDs is currently done twice during startup #6158

Closed
AlCalzone opened this issue Aug 14, 2023 · 4 comments · Fixed by #6401
Closed

switching to 16-bit node IDs is currently done twice during startup #6158

AlCalzone opened this issue Aug 14, 2023 · 4 comments · Fixed by #6401
Labels
bug Something isn't working

Comments

@AlCalzone
Copy link
Member

... once before and once after soft-reset.

@AlCalzone AlCalzone added the bug Something isn't working label Aug 14, 2023
@Hedda
Copy link
Contributor

Hedda commented Jan 19, 2024

@jtbraun did your PR #6401 include a fix for this too?

@jtbraun
Copy link
Contributor

jtbraun commented Jan 19, 2024

Not that I wrote or know of, but @AlCalzone rearranged some things to do long-range controller capability detection better, which may have changed this behavior. You can ask them, or just check the beta.

I haven't read the specs, but I normally would assume a soft-reset would/should reset the node-id size, and that you'd expect there to be a switch back to 16-bit nodes after the reset operation. Is that not the case?

@AlCalzone
Copy link
Member Author

AlCalzone commented Jan 19, 2024

All the issues linked from the PR should be fixed. But as the PR hasn't landed on the master branch yet, Github hasn't closed them.

And yes, I've reordered the initialization sequence to make a bit more sense.

@AlCalzone
Copy link
Member Author

This is merged since v12.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants