From 9ee1c3ba18c5510b2d1acb0f0c327abc8dc46e01 Mon Sep 17 00:00:00 2001 From: MarkAckert Date: Wed, 17 Apr 2024 16:35:38 -0400 Subject: [PATCH] don't quit early Signed-off-by: MarkAckert --- .github/scripts/manifest_verification/check_sources.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/scripts/manifest_verification/check_sources.js b/.github/scripts/manifest_verification/check_sources.js index 7c1598bbdd..3ea199eaa3 100644 --- a/.github/scripts/manifest_verification/check_sources.js +++ b/.github/scripts/manifest_verification/check_sources.js @@ -108,11 +108,12 @@ async function main() { } } + let didFail = false; + const failRepos = analyzedRepos.filter((item) => item.result === results.fail); if (failRepos != null && failRepos.length > 0) { core.warning('The following repositories do not have a matching tag or branch: ' + JSON.stringify(failRepos, null, {indent: 4})) core.setFailed('There are manifest sourceDependencies without a matching tag or branch. Review the output and update the manifest.') - return; } const warnRepos = analyzedRepos.filter((item) => item.name === results.warn) ; @@ -120,8 +121,8 @@ async function main() { core.warning('The following repositories have a branch instead of tag: ' + JSON.stringify(warnRepos, null, {indent: 4})) if (isRcOrMaster(baseRef)) { core.setFailed('Merges to RC and master require tags instead of branches for sourceDependencies.'); - return; } } + } main()