-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from Codecov and implement Sonar Cloud #473
Comments
@zFernand0 what is the benefit of sonar cloud? My experience with sonar is that it cannot be run on developers machines and significantly increases development feedback time. |
Hey @VitGottwald, Apologies for not replying any sooner. I hope that the conversation during today's call was able to resolve some of the concerns regarding the feedback time. |
@VitGottwald @zFernand0 @crawr @jellypuno you can register and view the webinar at https://webinars.devops.com/a-zowe-cli-enabled-roadmap The demo is focused on incorporating code quality tools like SonarQube into CI/CD pipelines for mainframe apps. It shows the value of SonarCloud and how to run the scan from the developer's machine using the Sonar Scanner CLI. |
Thank you for the answer @zFernand0! I have one more question. Is the sonar cloud configuration - the definition of linting rules, thresholds, etc. - stored in the form of a config file in the repo? Or is it stored in sonarcloud? |
We will be discussing more on this in the The short answer is yes, it's possible to configure SonarCloud from either the server or the repository. : ) |
I should have really asked this as the very first question. Can someone point me to an example of where Codecov was broken? |
Hey @VitGottwald, Here is a reference to the issue in codecov. codecov/codecov-bash#83 |
The report of the issue codecov/codecov-bash#83 says that a rebase on master resolves the problem. Did we try that in the cases we had a problem? |
oops, clicked on wrong button, sorry |
If I remember correctly we have done it in the past, and the issue seemed to go away, but because of the branch protection rules, we soon find ourselves in a similar situation as before. 😢 |
I did a small research today. All of the open source projects I could come up with either do not use code coverage within their pull requests at all or use Codecov. I wonder why it is not an issue for them but it is here. I wish I had such a broken branch to play with it. |
closing now that we have Sonar Cloud working |
Thank you for raising this issue. |
Re-opening since we are still using Codecov to report on patch/project coverage, and SonarCloud is not reporting coverage info. In the future, we should investigate migrating to SonarCloud for reporting coverage info on PRs and in the readme badge. |
closing in favor of: |
This should alleviate the burden of having to increase coverage on unrelated code since Codecov usually got confused between target branches.
Examples of sonar cloud usage are Zowe Imperative and Zowe CLI
The text was updated successfully, but these errors were encountered: