Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sample extensions to separate repo #2961

Closed
t1m0thyj opened this issue Jun 17, 2024 · 3 comments · Fixed by #3173
Closed

Move sample extensions to separate repo #2961

t1m0thyj opened this issue Jun 17, 2024 · 3 comments · Fixed by #3173
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have

Comments

@t1m0thyj
Copy link
Member

t1m0thyj commented Jun 17, 2024

Is your feature request related to a problem? Please describe.

The sample extensions may be inconvenient for users to try and for developers to maintain as part of the Zowe Explorer monorepo.

Describe the solution you'd like

Move the samples into their own repo, similar to what Microsoft does with https://github.com/microsoft/vscode-extension-samples

Describe alternatives you've considered

Leave the samples in the monorepo as they are now, but occasionally this may cause our build workflows to break.

Additional context

If we move the samples to a separate repo, we should set up a nightly workflow to ensure they build with the latest ZE API.

Copy link

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 10 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@t1m0thyj
Copy link
Member Author

Also, the menu-item-sample doesn't need to depend on the Zowe Explorer API. It only uses it for the type IZoweTreeNode. So either we could make the ZE API a dev dep, or stop using it entirely in favor of vscode.TreeItem.

@JTonda JTonda added the priority-low Legit issue but cosmetic or nice-to-have label Jun 18, 2024
@zowe-robot zowe-robot moved this from New Issues to Low Priority in Zowe Explorer for VS Code Jun 18, 2024
@JTonda
Copy link

JTonda commented Jun 18, 2024

Consider creating a blog on this.

@t1m0thyj t1m0thyj linked a pull request Oct 3, 2024 that will close this issue
15 tasks
@github-project-automation github-project-automation bot moved this from Low Priority to Closed in Zowe Explorer for VS Code Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants