fix: correct regex match condition in SyntaxValidator #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MAVRICK-1 <[email protected]>
MAVRICK-1
force-pushed
the
fix/2375-correct-regex-match-condition-in-SyntaxValidator
branch
from
2708e4d to
beff3d6
Compare
|
@zFernand0 can you review my PR |
zFernand0
requested changes
Dec 12, 2024
There was a problem hiding this comment.
- Could you add a quick changelog entry to the Imperative package?
packages/imperative/CHANGELOG.md- See the contribution guidelines for an example
- Could you add a test to avoid this sort of issue in the future?
packages/imperative/src/cmd/src/syntax/__tests__/SyntaxValidator.unit.test.ts
|
@zFernand0 looking into it |
|
@zFernand0 I am solving the 1) in this PR , |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2384 +/- ##
========================================
Coverage 91.28% 91.28%
========================================
Files 638 638
Lines 18207 18208 +1
Branches 3822 3930 +108
========================================
+ Hits 16621 16622 +1
Misses 1585 1585
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Hey @MAVRICK-1 , I think it'd be good to have the test added in the same PR 🙏 |
|
okay no issues🙂 on it
…On Fri, Dec 13, 2024 at 9:34 PM Fernando Rijo Cedeno < ***@***.***> wrote:
@zFernand0 I am solving the 1) in this PR , can solve no 2) in new PR?
Hey @MAVRICK-1 <https://github.com/MAVRICK-1> , I think it'd be good to
have the test added in the same PR 🙏
—
Reply to this email directly, view it on GitHub
<#2384 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDBQOEKNJCWGG4KPBXO5VQL2FMAPZAVCNFSM6AAAAABTOHSBJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBRG43DOMBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…positional argument validation test: add unit test for invalid positional argument regex validation Signed-off-by: MAVRICK-1 <[email protected]>
zFernand0
requested changes
Dec 17, 2024
packages/imperative/src/cmd/src/syntax/__tests__/SyntaxValidator.unit.test.ts
Outdated
Show resolved
Hide resolved
…regex-match-condition-in-SyntaxValidator
…sion test Signed-off-by: MAVRICK-1 <[email protected]>
|
@zFernand0 sry for the delay , it's fixed now |
t1m0thyj
requested changes
Dec 23, 2024
t1m0thyj
reviewed
Dec 23, 2024
t1m0thyj
requested review from
gejohnston,
pujal0909,
traeok,
jace-roell,
ATorrise and
awharn
Co-authored-by: Timothy Johnson <[email protected]> Signed-off-by: Rishi Mondal <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]> Signed-off-by: Rishi Mondal <[email protected]>
|
@t1m0thyj Thanks it's done , now i understood the formate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
fixed #2375
How to Test
Review Checklist
I certify that I have:
Additional Comments