Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System Tests to Handle Running Against APIML #1842

Merged
merged 19 commits into from
Nov 9, 2023

Conversation

awharn
Copy link
Member

@awharn awharn commented Nov 1, 2023

What It Does
Updates system tests to use the TestEnvironment functions to support running system tests against APIML.

How to Test
Run system tests against APIML?

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
packages/cli/src/zoslogs/ZosLogs.definition.ts 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

Signed-off-by: Andrew W. Harn <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing a lot of the code duplication around the session creation.
and also for fixing what looks like a long existing bug on the zos-logs command definition
LGTM! 😋

@zFernand0 zFernand0 added needs-ported Indicates that a PR needs to be ported (master - lts-incremental) no-changelog and removed no-changelog labels Nov 2, 2023
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn 😀

awharn and others added 2 commits November 8, 2023 13:23
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Copy link

sonarqubecloud bot commented Nov 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@awharn awharn merged commit b3f4144 into master Nov 9, 2023
19 of 20 checks passed
@awharn awharn deleted the fix-system-tests-for-apiml branch November 9, 2023 18:56
@awharn awharn restored the fix-system-tests-for-apiml branch November 9, 2023 18:56
@awharn awharn deleted the fix-system-tests-for-apiml branch November 9, 2023 18:56
@awharn awharn added the release-patch Indicates a patch to existing code has been applied label Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ported Indicates that a PR needs to be ported (master - lts-incremental) release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants