Restore Jest sonar reporter and bump workflow timeout #1840
Conversation
Signed-off-by: Andrew W. Harn <[email protected]>
awharn
requested review from
t1m0thyj,
gejohnston,
zFernand0,
traeok,
KevinLoesch1 and
ATorrise
Signed-off-by: Andrew W. Harn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
| @@ -134,6 +134,7 @@ module.exports = { | |||
| }], | |||
| ["github-actions", { "silent": false } ] | |||
| ], | |||
| "testResultsProcessor": "jest-sonar-reporter", | |||
There was a problem hiding this comment.
Should the "jest-sonar-reporter" be added to the reporters list above?
I'm kind of worried about the testResultsProcessor property, since it had a tendency to override some reporters (probably in older versions of jest). IDK if you remember, but that's why Dan's jest-stare reporter had a list of additionalReporters where we had the jest-junit and jest-sonar.
If this is not something to be concerned about in newer versions of Jest, then I'm fine with leaving it as-is.
There was a problem hiding this comment.
I tried that and it doesn't work. jest-sonar-reporter does not support the newer interface, and has been archived since 2019. Nothing else seems to exist outside of beta for providing Jest results to Sonar, so either we need to add this back, add something else to do a sonar scan on top of Jest tests (only thing I saw was in jest-sonar with a version of 0.2.1), or drop the use of Sonar.
| @@ -80,5 +81,8 @@ | |||
| "ts-jest": "^29.0.0", | |||
| "typedoc": "^0.23.10", | |||
| "typescript": "^4.0.0" | |||
| }, | |||
| "jestSonar": { | |||
There was a problem hiding this comment.
If we add the jest-sonar-reporterto the reporters list, we can move this configuration item there too 😋
There was a problem hiding this comment.
Again, tried that, Jest threw errors because the jest-sonar-reporter API wasn't compatible.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Seems like the reporter doesn't support the new syntax. 😢 |
zFernand0
added
the
release-current
What It Does
Restore Jest-Sonar scans and increase workflow timeout
How to Test
Review Checklist
I certify that I have:
Additional Comments