Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Imperative version independent, revert major bump #1838

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Make Imperative version independent, revert major bump #1838

merged 6 commits into from
Oct 30, 2023

Conversation

awharn
Copy link
Member

@awharn awharn commented Oct 27, 2023

What It Does
Reverts the major version bump that occurred to the Imperative subpackage
Updates the release configuration to manage Imperative's version independently

⚠️ All publishing workflows have been disabled until the incorrect versions can be deleted from JFrog ⚠️

How to Test

Review Checklist
I certify that I have:

Additional Comments

traeok
traeok approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM, thanks @awharn for quickly addressing this

@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@awharn
Fix integration test reports
629ee60 
Signed-off-by: Andrew W. Harn <[email protected]>
zFernand0
zFernand0 previously approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@awharn
One last fix
a254880 
Signed-off-by: Andrew W. Harn <[email protected]>
@zFernand0 zFernand0 dismissed their stale review October 30, 2023 14:04

waiting for build 😋

@zFernand0 zFernand0 self-requested a review October 30, 2023 14:04
@zFernand0 zFernand0 linked an issue Oct 30, 2023 that may be closed by this pull request
v3: Migrate the @zowe/imperative package to the zowe-cli monorepo #1695
Closed
t1m0thyj
t1m0thyj approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn!

@zFernand0 zFernand0 merged commit 9b2deb4 into master Oct 30, 2023
18 checks passed
@zFernand0 zFernand0 deleted the fix-everything branch October 30, 2023 18:39
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Oct 30, 2023
@github-actions
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

This was referenced Oct 31, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traeok traeok traeok approved these changes

@zFernand0 zFernand0 zFernand0 approved these changes

@gejohnston gejohnston gejohnston approved these changes

@t1m0thyj t1m0thyj t1m0thyj approved these changes

@KevinLoesch1 KevinLoesch1 Awaiting requested review from KevinLoesch1

@ATorrise ATorrise Awaiting requested review from ATorrise

Assignees
No one assigned
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v3: Migrate the @zowe/imperative package to the zowe-cli monorepo
5 participants
@awharn @t1m0thyj @gejohnston @zFernand0 @traeok