Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Consider deprecation or removal of the IProfileTypeConfiguration interface #2346

Closed
t1m0thyj opened this issue Nov 4, 2024 · 2 comments
Labels
enhancement New feature or request new The issue wasn't triaged yet v4 Prospective changes for v4

Comments

@t1m0thyj
Copy link
Member

t1m0thyj commented Nov 4, 2024

In Zowe V3, some properties on the IProfileTypeConfiguration interface were deprecated:

* @deprecated Only applies to V1 profiles. For team config, use nested profiles instead.
*/
dependencies?: IProfileDependency[];

* @deprecated Only applies to V1 profiles. For team config, validate with JSON schema instead.
*/
validationPlanModule?: string;

Once the deprecated properties are removed in V4, the only properties left will be type: string and schema: IProfileSchema. Since IProfileSchema also defines type, the IProfileTypeConfiguration interface may become an unnecessary wrapper that could be replaced with IProfileSchema.

@t1m0thyj t1m0thyj added enhancement New feature or request new The issue wasn't triaged yet v4 Prospective changes for v4 labels Nov 4, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Zowe CLI Squad Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 5 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@t1m0thyj
Copy link
Member Author

t1m0thyj commented Nov 4, 2024

Closing as invalid, since the IProfileSchema.type property is different from the profile type:

/**
* Specify "object". This is not the type name
* of the profile, but rather a description of the type of data structure (e.g. string,
* array). Your profile will be an object with one or more properties.
*/
type: string;

@t1m0thyj t1m0thyj closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
@github-project-automation github-project-automation bot moved this from New Issues to Closed in Zowe CLI Squad Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new The issue wasn't triaged yet v4 Prospective changes for v4
Projects
Status: Closed
Development

No branches or pull requests

1 participant