Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize CLI system tests for jobs to support more environments #2263

Closed
t1m0thyj opened this issue Sep 16, 2024 · 1 comment · Fixed by #2216
Closed

Generalize CLI system tests for jobs to support more environments #2263

t1m0thyj opened this issue Sep 16, 2024 · 1 comment · Fixed by #2216
Labels
enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits testing

Comments

@t1m0thyj
Copy link
Member

  1. Cancel Jobs system test assumes job ID is one less than most recently submitted job

    The jobid should be accessible here - I believe it was created by the submit_job.sh script on line 58.

    Could we grab the jobid from there rather than assuming it is one less?

    Originally posted by @t1m0thyj in System tests should cleanup after themselves #2216 (comment)

    // Calculate the previous job ID (one less) - jobid created by test before, inaccessible until now
    const jobidNumber = parseInt(jobid.replace('JOB', ''), 10); //Extract the numeric part of the job ID
    const previousJobid = 'JOB' + String(jobidNumber - 1).padStart(5, '0'); // then decrement by 1, assuming 5 digits in the job ID

  2. Search Jobs system test has hardcoded job name

    JOB_NAME = REAL_SESSION.ISession.user.substring(0, JOB_LENGTH).toUpperCase() + "SF";

@t1m0thyj t1m0thyj added enhancement New feature or request testing priority-low Legit issue but cosmetic or nice-to-have labels Sep 16, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Zowe CLI Squad Sep 16, 2024
Copy link

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 5 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@JTonda JTonda moved this from New Issues to Low Priority in Zowe CLI Squad Sep 18, 2024
@JTonda JTonda added priority-medium Not functioning - next quarter if capacity permits and removed priority-low Legit issue but cosmetic or nice-to-have labels Sep 18, 2024
@JTonda JTonda moved this from Low Priority to Medium Priority in Zowe CLI Squad Sep 18, 2024
@t1m0thyj t1m0thyj linked a pull request Oct 14, 2024 that will close this issue
4 tasks
@github-project-automation github-project-automation bot moved this from Medium Priority to Closed in Zowe CLI Squad Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits testing
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants