-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify extenders when changes to the vault have been made #1987
Comments
Thank you for raising this enhancement request. |
A lot of great discussion has occurred around this. Here is a TL;DR:
Implementation:
|
Removed assignees until someone is assigned to work on this issue. |
Thank you so much for the support on the Imperative end of this work! This should be a very impactful change for our users :) |
With the Event OP PR merged and published, I believe we can close this issue. Zowe Explorer will have this implemented in: |
Is your feature or enhancement request related to a problem or limitation? Please describe
As a developer for Zowe Explorer, when a user makes changes to their credentials in the vault through
imperative
, our extenders have no actual way to find out when a change to the vault is made, this could be notified when any CRUD operation is done using imperative when interacting with the vault (this being the keychain, kubernetes secrets, etc).Describe your enhancement idea
As discussed with @t1m0thyj this could be implemented by creating an event emitter called
onVaultUpdate()
that when fired will notify anyone using imperative for managing credentials that a change in the vault has occured regarding their credentials, furthermore allowing up to date information to be synced among Zowe profiles.In Zowe Explorer we have already something like this for changes on our team config profiles (v2) called
onProfilesUpdate()
which fires when any CRUD operation is performed for team config profiles. This newonVaultUpdate()
function could be something we could attach to our existing event emitter in order to keep up to date both important components of a users profile data, this being:a. The team configuration profile
b. The vault storing the profile's credentials
Describe alternatives you've considered
Currently no alternatives, only the fact that we can trigger our own event emitter when performing very specific credential operations in Zowe Explorer, implementing this in imperative could provide full coverage for keeping credential data up to date accross extensions using imperative.
Provide any additional context
The text was updated successfully, but these errors were encountered: