Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document defaults.yaml consequences #4014

Open
Martin-Zeithaml opened this issue Nov 20, 2024 · 0 comments
Open

Document defaults.yaml consequences #4014

Martin-Zeithaml opened this issue Nov 20, 2024 · 0 comments
Assignees
Labels
area: install and config Issues related to z/OS install and config release: V2 Zowe V2 content release: V3 Zowe V3 content

Comments

@Martin-Zeithaml
Copy link
Collaborator

Martin-Zeithaml commented Nov 20, 2024

When updating zowe.yaml, user might think, that commenting/deleting a component will disable such component. This is not true anymore if such component is set in defaults. The default.yaml is "hidden" from the user point of view. Let's show this on the following example, where user will prepare config, which is different comparing to merged config:

User's config

components:
#  comp1:
 #   enabled: true
  comp2:
    enabled: true

Defaults.yaml

components:
  comp1:
    enabled: true
    port: 123
    timeTraveling: DeLorean

Merged result

components:
  comp1:
    enabled: true
    port: 123
    timeTraveling: DeLorean
  comp2:
    enabled: true

Solution

components:
# User must (in this case) keep comp1 and disabled it
  comp1:
    enabled: false
  comp2:
    enabled: true

Bonus: This is valid for configmgr. For example, if zwe command is used in shell version, there might not be merged config and then the behavior will be different comparing to javascript version of the same command.

@Martin-Zeithaml Martin-Zeithaml added area: install and config Issues related to z/OS install and config release: V2 Zowe V2 content release: V3 Zowe V3 content labels Nov 20, 2024
@Martin-Zeithaml Martin-Zeithaml self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: install and config Issues related to z/OS install and config release: V2 Zowe V2 content release: V3 Zowe V3 content
Projects
None yet
Development

No branches or pull requests

1 participant