Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove replay protection disabling requirement #3788

Merged
merged 9 commits into from
Aug 2, 2024

Conversation

pablocarle
Copy link
Contributor

Describe your pull request here:

Update requirements for passtickets

List the file(s) included in this PR:

Pablo Hernán Carle added 3 commits July 31, 2024 14:12
Signed-off-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]>
Signed-off-by: Pablo Hernán Carle <[email protected]>
Copy link

😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.

  • Add the label review: doc.
  • Identify your content topic with a label. (Examples: area: apiml, area: cli, area: install and config, etc.)
  • Specify the major Zowe release(s) for your content. (Examples: release: V1, release: V2, release: V3)
    • If adding content that needs to be removed from V3 documentation, add the V3 N/A tag.
  • Select the master branch if your PR updates content that is on the live site. Select docs-staging if your PR updates content for a future release.
  • Notify the Doc Squad about this PR. If you don't know whom should review your content, message the #zowe-doc Slack channel. If you know which Doc Squad writer should approve your content, add that person as a reviewer.

Need help? Contact the Doc Squad in the #zowe-doc Slack channel.

Copy link

⚠️ Looks like something is wrong with the PR description. Remember to add a description and the file(s) included in this PR.

If you have addressed this issue already, refresh this page in your browser to remove this comment.

@dkelosky
Copy link
Contributor

A couple of discussion points:

  • should we add a note in the doc that states how we used to require replay protection be disabled?
  • for folks that previously had added APPLDATA('NO REPLAY PROTECTION') - should they revert this change?

For the first bullet, I think the answer is "no", but I'm curious for other's input. For the second, I'm not sure.

@dkelosky
Copy link
Contributor

Fix #3711

Signed-off-by: Pablo Hernán Carle <[email protected]>
@pablocarle
Copy link
Contributor Author

A couple of discussion points:

* should we add a note in the doc that states how we used to require replay protection be disabled?

* for folks that previously had added `APPLDATA('NO REPLAY PROTECTION')` - should they revert this change?

For the first bullet, I think the answer is "no", but I'm curious for other's input. For the second, I'm not sure.

I think the second one makes sense, the only issue I see is that we just verified that it's not needed but there were no code changes recently. So, should we state that it's safe to enable the replay protection from 2.17 (latest release)?

@pablocarle pablocarle added area: apiml This issue is related to Zowe API Mediation Layer release: V2 Zowe V2 content area: install and config Issues related to z/OS install and config review: doc Needs review by Doc Squad member labels Aug 2, 2024
Signed-off-by: Pablo Hernán Carle <[email protected]>
Copy link

github-actions bot commented Aug 2, 2024

@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 12:51 Inactive
Signed-off-by: Pablo Hernán Carle <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 14:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2024 15:01 Inactive
@anaxceron anaxceron merged commit e5c39d2 into master Aug 2, 2024
4 checks passed
@anaxceron anaxceron deleted the reboot/fix/replay-protection branch August 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: apiml This issue is related to Zowe API Mediation Layer area: install and config Issues related to z/OS install and config release: V2 Zowe V2 content review: doc Needs review by Doc Squad member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants