Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Fluent.js and convert all existing reader strings #143

Open
dstillman opened this issue Oct 12, 2024 · 1 comment
Open

Use Fluent.js and convert all existing reader strings #143

dstillman opened this issue Oct 12, 2024 · 1 comment

Comments

@dstillman
Copy link
Member

#142 (comment)

@mrtcode mrtcode changed the title Placeholder support in localized strings Use Fluent.js and convert all existing reader strings Oct 15, 2024
@mrtcode
Copy link
Member

mrtcode commented Oct 15, 2024

As discussed in #142 (comment), use Fluent.js for all builds except Zotero client, because it already supports Fluent out of the box.

Convert all existing strings.

Note that PDF.js also uses Fluent.js and likely includes it in its source, even though we don't use localized strings from PDF.js. Check how much space it adds to the PDF.js build and consider excluding it if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants