Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Version number is baked into local storage keys #370

Open
eatyourgreens opened this issue Feb 9, 2018 · 2 comments
Open

Version number is baked into local storage keys #370

eatyourgreens opened this issue Feb 9, 2018 · 2 comments

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Feb 9, 2018

localStorageServiceProvider
.setPrefix(appConfig.appTitle + '-' + appInfo.version);

So, any stored data on volunteers' browsers will be unreadable if the version number is changed, and the old keys won't be deleted by the current code.

Simplest solution is probably never to change SW's version number. 😞

@simoneduca
Copy link
Contributor

Why would removing the version bit not work?

@eatyourgreens
Copy link
Contributor Author

That would change the key names, leading to the same problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants