-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations #53
Comments
I'm probably missing something, but from how we plan of building translations, no particular support is needed. What were you thinking? |
I mean translating the lab itself. Right now it's all just in English. ETA: We need to add counterpart or yahoo's react-intl to translate the strings of all the help text, etc. I would presume the app you're building for the translation volunteers to submit translations for projects would also have an area to translate zooniverse.org itself and the lab. |
At the moment, we're just building an editor for the translatable resources stored in Panoptes, so I'm assuming there will be an The UI text will also need an editor, but that's a separate problem. I'm completely okay with moving the UI dictionary into its own GitHub repo (it is just a big JSON blob, for counterpart at least), and asking volunteers to open PRs with translations. |
I've opened zooniverse/pandora#6 to list project resources that would need to be translated. Will organisations use |
@eatyourgreens yes: https://github.com/zooniverse/Panoptes/blob/master/app/serializers/organization_content_serializer.rb Related to translations, @zwolf and I debugged zooniverse/panoptes#2318 yesterday and discovered that pages are currently locked to English as This affects both orgs and projects since orgs is reusing the pages controller. We found that if the primary language parent resource, in this case the org, did not match the language set for the page, then the request for the pages would return as an empty array. I haven't added counterpart to the lab app yet and was setting the primary language for orgs on create using the window's
|
The navigator property is readonly, isn't it? My argument against that would be the case where you're using a computer in a foreign country, so you don't control |
By the way, you might find that the language code is currently locked to |
For a user I think we would want to store their language preference in their project preferences? Thanks for explaining a case where the browser setting wouldn't be helpful. The staging orgs we're building with are already fixed to now be set to |
Preferences sounds good for language codes. I think the older translation code used on Penguin Watch and Galaxy Zoo gets your language from preferences, so that it's saved across visits. |
Add translation support before we get to far with this.
The text was updated successfully, but these errors were encountered: