Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing language content in project serializer #1212

Closed
camallen opened this issue Jul 29, 2015 · 7 comments
Closed

Handle missing language content in project serializer #1212

camallen opened this issue Jul 29, 2015 · 7 comments

Comments

@camallen
Copy link
Contributor

Here and might be related to #1091

I get an error on staging using the apiary docs http://docs.panoptes.apiary.io/#reference/projects/project-collection/list-all-projects?console=1, originally reported here.

@camallen camallen added the bug label Jul 29, 2015
@camallen camallen added this to the Panoptes 'sprint' 2 milestone Jul 29, 2015
@edpaget
Copy link
Contributor

edpaget commented Jul 29, 2015

It should always at least return the primary_language content for a project from here, and a project shouldn't valid unless it has some sort of content. Are we sure this is the issue?

@camallen
Copy link
Contributor Author

Maybe not, might be a problematic project. I didn't debug properly just had a quick look at the code.

@edpaget
Copy link
Contributor

edpaget commented Jul 29, 2015

It looks like there are ~500 projects on staging that are invalid.

@edpaget
Copy link
Contributor

edpaget commented Jul 29, 2015

I'm fine with just deleting them.

@camallen
Copy link
Contributor Author

old weather and retina's are two that we need to keep in the meantime, otherwise yeah - it's staging...

@chrissnyder
Copy link
Contributor

Would it be useful to have a short description on how to setup an application on production somewhere? Happy to put this together myself. I think people are just following the Ouroboros model of dev/production, when it doesn't make sense here because we can label the project as private while in development.

@camallen
Copy link
Contributor Author

@chrissnyder I think this is a vestige of us having staging ready before prod. We should encourage everyone to build on prod now. Not sure if i know anyone building on staging anymore.

So the real problem here is the invalid projects are linked to deactivated user accounts. We are including 'deleted' (think deactivated) resources in our api responses instead of excluding them. All of these seem to be from front end testing on staging and it's something that should be fixed by adding scopes on our controller controled_resources scope to only find active resources.

Closing this, will open a new issue and submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants