Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relevant reductions from project level reducers #1502

Open
lcjohnso opened this issue Feb 9, 2023 · 1 comment
Open

Allow relevant reductions from project level reducers #1502

lcjohnso opened this issue Feb 9, 2023 · 1 comment

Comments

@lcjohnso
Copy link
Member

lcjohnso commented Feb 9, 2023

Current Behavior: Reducer configurations can specify relevant reductions, additional input information necessary for reducer computations. Example: For PH TESS, its subject reducer can define relevant user reductions via the user_reducer_keys configuration item. However, it is implicitly assumed in the code that the relevant reduction shares the same reducible as the reducer -- for the above example, the workflow.

Desired Behavior: Allow a configurable reducible_id that accompanies the reduction key input via [subject,user]_reducer_key. In most cases, this should default to the same reducible_id as for the reducer where it is being configured, but allowing a different reducible_id & reducible_type will allow project level reductions to be imported for use by a reducer. Example 1: a project level user reduction could be import by a workflow level subject reducer (e.g., project level user skill reductions imported into a workflow level subject probability reducer). Example 2: a workflow level subject reduction could be imported by a project level user reducer (e.g., workflow level subject difficulty reduction imported into a project level user skill reducer).

@lcjohnso
Copy link
Member Author

lcjohnso commented Feb 9, 2023

Specifically in code -- reducible for relevant reductions is assumed to be same as for reducer. See example here:

UserReduction.where(user_id: user_ids, reducible: reducible, reducer_key: reducer.user_reducer_keys)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant