Transcription projects break the lab tasks editor

[eatyourgreens]

Current behavior

When a project has the transcription-task flag enabled, an extra block of code is run for each new workflow task, which adds workflow.steps to the workflow. This runs for all project workflows, even if they do not use a transcription task.

Panoptes-Front-End/app/pages/lab/workflow.jsx

Lines 563 to 571 in 37c2f8b

	if (this.canUseTask(this.props.project, "transcription-task")) {
	const nextStepID = this.getNextStepID();
	const newStep = [nextStepID, { taskKeys: [nextTaskID] }];
	const newSteps = [...this.props.workflow.steps, newStep];
	changes["steps"] = newSteps;
	if ((this.props.workflow.configuration.classifier_version == null) || (this.props.workflow.configuration.classifier_version !== '2.0')) {
	changes['configuration.classifier_version'] = "2.0";
	}
	}

This leads to weird behaviour in the task editor. If you use the 'first task' dropdown to change the first task, your changes will be ignored by the new classifier.

It also adds classifier_version: 2.0 to all workflows, even if they don't use new classifier features.

Steps to replicate

I've got a test workflow set up which works fine in PFE, but is broken in the new classifier because workflow.steps was created by the lab editor and set to an invalid value. The workflow has two questions, but the new classifier shows the second task and ignores the first question:

• PFE version: https://master.pfe-preview.zooniverse.org/projects/eatyourgreens/-project-testing-ground/classify?reload=0&workflow=3761&env=staging
• FEM version: https://frontend.preview.zooniverse.org/projects/eatyourgreens/-project-testing-ground/classify/workflow/3761?env=staging