refactor(shields): Use dynamic display PD for ZMK Uno.

zmkfirmware · Jul 5, 2024 · 37acfeb · 37acfeb
1 parent 09050ef
commit 37acfeb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 17 deletions.
diff --git a/app/boards/shields/zmk_uno/Kconfig.defconfig b/app/boards/shields/zmk_uno/Kconfig.defconfig
@@ -6,6 +6,8 @@ if SHIELD_ZMK_UNO_BASE
 config SHIELD_ZMK_UNO_PM
     bool "ZMK Uno Automatic Power Management"
     default y
+    select ZMK_POWER_DOMAINS
+    select ZMK_POWER_DOMAINS_DYNAMIC_DEFAULT
     select PM_DEVICE
     select PM_DEVICE_POWER_DOMAIN
     select PM_DEVICE_RUNTIME

diff --git a/app/boards/shields/zmk_uno/zmk_uno.dtsi b/app/boards/shields/zmk_uno/zmk_uno.dtsi
@@ -9,22 +9,6 @@
 
 &arduino_i2c {
     status = "okay";
-
-    oled: ssd1306@3c {
-        compatible = "solomon,ssd1306fb";
-        reg = <0x3c>;
-        label = "DISPLAY";
-        width = <128>;
-        height = <64>;
-        segment-offset = <0>;
-        page-offset = <0>;
-        display-offset = <0>;
-        multiplex-ratio = <63>;
-        prechargep = <0x22>;
-
-        power-domain = <&core_power_domain>;
-        zephyr,pm-device-runtime-auto;
-    };
 };
 
 nice_view_spi: &arduino_spi {
@@ -66,10 +50,13 @@ nice_view_spi: &arduino_spi {
         zmk,backlight = &backlight;
         zmk,underglow = &led_strip;
         zephyr,display = &oled;
+        zmk,display-default-power-domain = &core_power_domain;
     };
 
     core_power_domain: core_power_domain {
-        compatible = "power-domain-gpio";
+        // The "power-domain" compatible is needed for any PDs used for that have dynamic deps,
+        // e.g. for displays or RGB not assigned to the PD in the devicetree statically.
+        compatible = "power-domain-gpio", "power-domain";
         startup-delay-us = <2000>;
         off-on-delay-us = <2000>;
         enable-gpios = <&arduino_header 0 GPIO_ACTIVE_LOW>;