This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Show method for render statements #988
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrigoriiBerezin
force-pushed
the
add_show_and_tests
branch
from
4fbc498 to
79429be
Compare
|
@jczuchnowski review plz when you will have free time. |
- add tests on `show` for all sql dialects - add `show` info in README
GrigoriiBerezin
force-pushed
the
add_show_and_tests
branch
2 times, most recently
from
6a54403 to
b3c8ae8
Compare
- add tests on `show` for all sql dialects - add `show` info in README
GrigoriiBerezin
force-pushed
the
add_show_and_tests
branch
from
b3c8ae8 to
80f7afd
Compare
Grryum
reviewed
May 3, 2024
| @@ -54,6 +54,22 @@ trait Sql { | |||
|
|
|||
| def renderInsert[A: Schema](insert: Insert[_, A]): SqlStatement | |||
|
|
|||
| implicit class readOps(read: Read[_]) { | |||
There was a problem hiding this comment.
seems that this implicit class should extend AnyVal
There was a problem hiding this comment.
Unfortunately, can't do it due to show method dependency on realization of trait, which is prohibited for value class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showmethod for statementsshowfor all sql dialectsshowinfo in README