Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the repo with all the linter based warning #103

Open
shahsmit14 opened this issue Feb 8, 2022 · 0 comments
Open

Fix the repo with all the linter based warning #103

shahsmit14 opened this issue Feb 8, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@shahsmit14
Copy link
Collaborator

The repo has linter running but there are quite some warnings which are not breaking but needs to be resolved.

Example pipeline: https://github.com/zillow/luminaire/runs/5104474237?check_suite_focus=true

11    C901 'DataExploration._detrender' is too complex (13)
7     E122 continuation line missing indentation or outdented
12    E127 continuation line over-indented for visual indent
29    E128 continuation line under-indented for visual indent
2     E[203](https://github.com/zillow/luminaire/runs/5104474237?check_suite_focus=true#step:6:203) whitespace before ':'
2     E225 missing whitespace around operator
2     E231 missing whitespace after ','
3     E266 too many leading '#' for block comment
22    E302 expected 2 blank lines, found 1
10    E303 too many blank lines (2)
9     E501 line too long (134 > 127 characters)
1     E714 test for object identity should be 'is not'
2     E722 do not use bare 'except'
16    F401 'luminaire.optimization' imported but unused
5     F403 'from luminaire.exploration.data_exploration import *' used; unable to detect undefined names
34    F405 'DataExploration' may be undefined, or defined from star imports: luminaire.exploration.data_exploration
1     F841 local variable 'e' is assigned to but never used
1     W291 trailing whitespace
3     W292 no newline at end of file
4     W293 blank line contains whitespace
1     W391 blank line at end of file
@shahsmit14 shahsmit14 added the bug Something isn't working label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant