Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete sequence diagram in DG #12

Open
zhizhizhizhizhi opened this issue Nov 13, 2020 · 1 comment
Open

Incomplete sequence diagram in DG #12

zhizhizhizhizhi opened this issue Nov 13, 2020 · 1 comment
Labels
severity.Medium status.Done type.DocumentationBug

Comments

@zhizhizhizhizhi
Copy link
Owner

zhizhizhizhizhi commented Nov 13, 2020 •
edited
Loading

Page 26 Figure 26: the rightest side seems to be cut off.
Screenshot 2020-11-13 at 5.41.32 PM.png
@nus-se-bot
Copy link

nus-se-bot commented Nov 18, 2020 •
edited by zhizhizhizhizhi
Loading

Team's Response

Intentionally omitted for brevity and clarity as the focus of this section was on how feedtimes are added and it was not relevant to show the Model

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: This representation causes confusion as to whether the diagram is complete. It would be less confusing to briefly include the model entity like the sequence diagram of the delete command in the other part of the DG. The focus will still be on the Logic component and there is still brevity and the diagram will be more conventional. Therefore I believe it is still a documentation bug.
Screenshot 2020-11-20 at 11.12.27 PM.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity.Medium status.Done type.DocumentationBug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhizhizhizhizhi @nus-se-bot