Improve Docker Compose handling #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartmkraus
requested review from
szmktk,
tgbdc7,
arkjedrz,
miniMax18 and
MartaSien
arkjedrz
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Why is it required to have both docker-compose.base.yml and docker-compose.yml?
It seems docker-compose,yml restates the content.
There was a problem hiding this comment.
I've looked a bit into the future with the development and production environments in mind. Maintaining this structure makes it easier to add environment-specific configurations later without having to restructure that configuration. (Core configuration, Development overrides, Production overrides).
There was a problem hiding this comment.
Related to this issue: zeton_django Issue #119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
Here's how this solution works:
docker-compose.base.ymlcontains all shared configurationdocker-compose.ymlthat extends from base and overrides necessary valueszeton_full_stackrepo has itsdocker-compose.ymlthat includes everything including the React clientI think that benefits of this are:
docker-compose.base.ymlIn the near future it would be nice add a
docker-compose.override.ymlin each repository for environment-specific settings for example: to make local development easier. I think @arkjedrz expressed his concerns about the distinction between production and development environments.