Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert go-tss to v21/v22 version #3215

Merged
merged 1 commit into from
Nov 25, 2024
Merged

chore: revert go-tss to v21/v22 version #3215

merged 1 commit into from
Nov 25, 2024

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Nov 25, 2024 •
edited
Loading

V22.1.2 is causing signing to stop on testnet. Revert go-tss to v21/v22 version.

@gartnera gartnera added the no-changelog Skip changelog CI check label Nov 25, 2024
@gartnera gartnera requested a review from a team November 25, 2024 18:28
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

gartnera
gartnera commented Nov 25, 2024
View reviewed changes
cmd/zetaclientd/start.go
Comment on lines +220 to +224
knownPeersAddrInfo := lo.Map(knownPeersTss, func(p tss.PeerInfo, _ int) peer.AddrInfo {
return peer.AddrInfo{
ID: peer.ID(p.ID),
}
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tss.PeerInfo doesn't quite fit into peer.AddrInfo so this is the best I can do.

@brewmaster012
Copy link
Collaborator

what's the go-tss commit that this reverts to?
I can't seem to find the commit there

@gartnera
Copy link
Member Author

gartnera commented Nov 25, 2024 •
edited
Loading

what's the go-tss commit that this reverts to? I can't seem to find the commit there

It's the commit from release/v21. I don't think disabling DHT was never merged into go-tss main.

@brewmaster012
Copy link
Collaborator

what's the go-tss commit that this reverts to? I can't seem to find the commit there

It's the commit from release/v21. I don't think disabling DHT was never merged into go-tss main.

OK sounds good.

@gartnera gartnera merged commit bccb1cc into release/v23 Nov 25, 2024
35 checks passed
@gartnera gartnera deleted the v23-revert-tss branch November 25, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brewmaster012 brewmaster012 brewmaster012 approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@swift1337 swift1337 swift1337 approved these changes

@lumtis lumtis Awaiting requested review from lumtis lumtis is a code owner

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

@skosito skosito Awaiting requested review from skosito skosito is a code owner

@fbac fbac Awaiting requested review from fbac

Assignees
No one assigned
Labels
breaking:cli no-changelog Skip changelog CI check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gartnera @brewmaster012 @swift1337 @kingpinXD