Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

feat: Support OKX extension wallet to send Bitcoin. #39

Closed
wants to merge 6 commits into from

Conversation

lukema95
Copy link

Copy link

vercel bot commented Jul 19, 2024

@lukema95 is attempting to deploy a commit to the Zeta Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 19, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lukema95
Copy link
Author

Now I can successfully send the testnet BTC with the following code, but the Testnet seems to lack the getAccounts interface at the moment:

  const callOkxWallet = async (params: Params) => {
    if (!window.okxwallet) return alert("OKX wallet not installed")
    const okxwallet = window.okxwallet
    // const account = (await okxwallet?.bitcoinTestnet?.getAccounts())?.[0]
    // if (!account) return alert("No account found")
    try {
      const txHash = await okxwallet.bitcoinTestnet.send(
        {
          // from: account,
          from: "tb1pupdwvec0gy6kh5wl953fpmj33uww0994fpcxamk6rdk6kanzl6xsq35z77",
          to: params.tss,
          value: params.amount / 1e8,
          memo: `0x${params.contract}${params.message}`,
          memoPos: 1,
        }
      );
      return alert(`Broadcasted a transaction: ${txHash}`)
    } catch (e: any) {
      throw new Error(e.message || "Error sending OKX Bitcoin transaction")
    }

  }

@fadeev
Copy link
Member

fadeev commented Jul 20, 2024

@lukema95 can you try using okxwallet?.bitcoinTestnet?.connect(), instead?

@lukema95
Copy link
Author

@lukema95 can you try using okxwallet?.bitcoinTestnet?.connect(), instead?

it worked, my bad😂

@fadeev
Copy link
Member

fadeev commented Jul 29, 2024

@lukema95 thanks for working on this! As the example frontend repo is getting deprecated, I've migrated the changes proposed in this PR to the UniversalKit repo: https://github.com/zeta-chain/universalkit/

@fadeev fadeev closed this Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants